Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 18 Apr 2024 16:36:13 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A |
| |
On Thu, Apr 18, 2024 at 09:01:19PM +0800, Chukun Pan wrote: > According to https://radxa.com/products/rock3/3a, > the name of this board should be "Radxa ROCK 3A". > Also update compatible to match the model name. > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 99bd5e2c76a0..88e9e0011953 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -772,9 +772,9 @@ properties: > - const: radxa,rock2-square > - const: rockchip,rk3288 > > - - description: Radxa ROCK3 Model A > + - description: Radxa ROCK 3A
This is fine, but...
> items: > - - const: radxa,rock3a > + - const: radxa,rock-3a
...this was added 2 years ago, I think it's too late to change it, NAK.
Cheers, Conor.
> - const: rockchip,rk3568 > > - description: Radxa ROCK 5 Model A > -- > 2.25.1 > [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |