lkml.org 
[lkml]   [2024]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] Drivers: hv: Cosmetic changes for hv.c and balloon.c
On Thu, Apr 11, 2024 at 10:28:03PM -0700, Aditya Nagesh wrote:
> Fix issues reported by checkpatch.pl script in hv.c and
> balloon.c
> - Remove unnecessary parentheses
> - Remove extra newlines
> - Remove extra spaces
> - Add spaces between comparison operators
> - Remove comparison with NULL in if statements
>
> No functional changes intended
>
> Signed-off-by: Aditya Nagesh <adityanagesh@linux.microsoft.com>
> ---
> [V3]
> Fix alignment issues in multiline function parameters.
>
> [V2]
> Change Subject from "Drivers: hv: Fix Issues reported by checkpatch.pl script"
> to "Drivers: hv: Cosmetic changes for hv.c and balloon.c"
>
> drivers/hv/hv.c | 35 +++++++-------
> drivers/hv/hv_balloon.c | 101 +++++++++++++++-------------------------
> 2 files changed, 54 insertions(+), 82 deletions(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index a8ad728354cb..4906611475fb 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -45,7 +45,7 @@ int hv_init(void)
> * This involves a hypercall.
> */
> int hv_post_message(union hv_connection_id connection_id,
> - enum hv_message_type message_type,
> + enum hv_message_type message_type,

This line is fixed now, but now below line is unaligned.

> void *payload, size_t payload_size)
> {

<snip>

>
> if (req->more_pages == 1)
> return;
> @@ -1415,7 +1395,7 @@ static int dm_thread_func(void *dm_dev)
>
> while (!kthread_should_stop()) {
> wait_for_completion_interruptible_timeout(
> - &dm_device.config_event, 1*HZ);
> + &dm_device.config_event, 1 * HZ);

IMO, we can move this to previous line, as now 100 characters are allowed in single line.


Once fixed above,
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>

- Saurabh


\
 
 \ /
  Last update: 2024-05-27 16:46    [W:0.036 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site