lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 04/16] ACPI: processor: Move checks and availability of acpi_processor earlier

> > result = -ENODEV;
> > @@ -469,15 +483,16 @@ static void acpi_processor_remove(struct
> > acpi_device *device)
> > device_release_driver(pr->dev);
> > acpi_unbind_one(pr->dev);
> >
> > - /* Clean up. */
> > - per_cpu(processor_device_array, pr->id) = NULL;
> > - per_cpu(processors, pr->id) = NULL;
> > -
> > cpu_maps_update_begin();
> > cpus_write_lock();
> >
> > /* Remove the CPU. */
> > arch_unregister_cpu(pr->id);
> > +
> > + /* Clean up. */
> > + per_cpu(processor_device_array, pr->id) = NULL;
> > + per_cpu(processors, pr->id) = NULL;
> > +
>
>
> Shouldn't above change come after acpi_unmap_cpu() i.e. after next line?
>
>
> > acpi_unmap_cpu(pr->id);
Agreed - that is more logically correct. I'll move it for v7.

Thanks,

Jonathan

\
 
 \ /
  Last update: 2024-04-17 17:19    [W:0.134 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site