lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] string: Implement KUnit test for str*cmp functions
From
On 4/17/24 15:53, Andy Shevchenko wrote:
>> There are already 2 other KUnit tests in `lib/` covering different groups of
>> string functions separately (lib/strscpy_kunit.c, lib/strcat_kunit.c), so
>> this patch just follows this pattern. I believe it makes sense: the tests
>> are separated to cover one specific group of string functions with a similar
>> purpose
>
> We have handful of the string functions, are you going to have a file per
> function? Isn't it way too many?
>
> P.S>
> Having those does not prove it's a correct approach. I would rather expect
> somebody to incorporate those into string_kunit.c.
>

Makes sense. Also, probably having all of them in `string_kunit.c` would
fit better into the KUnit test style guidelines.

I'll merge this strcmp test into `string_kunit.c` in V2 of this patch,
thank you for the review.

--
Kind regards,
Ivan Orlov


\
 
 \ /
  Last update: 2024-04-17 17:13    [W:0.049 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site