lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 5/5] PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend
    On Wed, Apr 17, 2024 at 10:38:04AM -0400, Frank Li wrote:
    > On Wed, Apr 17, 2024 at 03:49:44PM +0530, Manivannan Sadhasivam wrote:
    > > On Mon, Apr 15, 2024 at 03:33:29PM -0400, Frank Li wrote:
    > > > + /*
    > > > + * Allocate the resource for MSG TLP before programming the iATU outbound window in
    > > > + * dw_pcie_setup_rc(). Since the allocation depends on the value of 'region_align', this has
    > > > + * to be done after dw_pcie_iatu_detect().
    > >
    > > Please wrap the comments to 80 columns.
    >
    > New code style is 100 columns. does comments still stick to 80 columns?

    I care more about files being consistent internally than I do about
    adhering to a new 100 column rule.

    With very few exceptions, pcie-designware-host.c fits in 80 columns.
    I think there's no point in adding a comment using 100 columns. That
    leadds to either a window sized to accommodate 100 columns, where 20
    columns are wasted for all the existing code and comments, or a window
    sized for 80 columns, where the new comment looks ugly. Neither is
    attractive.

    Bjorn

    \
     
     \ /
      Last update: 2024-04-17 17:10    [W:3.473 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site