Messages in this thread | | | Date | Wed, 17 Apr 2024 14:09:35 +0200 | From | Oscar Salvador <> | Subject | Re: [PATCH v1 2/2] fs/proc/task_mmu: convert smaps_hugetlb_range() to work on folios |
| |
On Wed, Apr 17, 2024 at 11:23:13AM +0200, David Hildenbrand wrote: > Let's get rid of another page_mapcount() check and simply use > folio_likely_mapped_shared(), which is precise for hugetlb folios. > > While at it, use huge_ptep_get() + pte_page() instead of ptep_get() + > vm_normal_page(), just like we do in pagemap_hugetlb_range().
That is fine because vm_normal_page() tries to be clever about mappings which hugetlb does not support, right?
> > No functional change intended. > > Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
-- Oscar Salvador SUSE Labs
| |