Messages in this thread | | | Date | Wed, 17 Apr 2024 11:30:09 +0200 (CEST) | From | Romain Gantois <> | Subject | Re: [PATCH net-next v3 2/5] net: stmmac: introduce pcs_init/pcs_exit stmmac operations |
| |
Hi Serge,
On Tue, 16 Apr 2024, Serge Semin wrote:
> I am currently working on my Memory-mapped DW XPCS patchset cooking: > https://lore.kernel.org/netdev/20231205103559.9605-1-fancer.lancer@gmail.com/ > The changes in this series seems to intersect to what is/will be > introduced in my patchset. In particular as before I am going to > use the "pcs-handle" property for getting the XPCS node. If so what > about collecting PCS-related things in a single place. Like this: > > int stmmac_xpcs_setup(struct net_device *ndev) > { > ... > > if (priv->plat->pcs_init) { > return priv->plat->pcs_init(priv); /* Romain' part */ > } else if (fwnode_property_present(priv->plat->port_node, "pcs-handle")) { > /* My DW XPCS part */ > } else if (priv->plat->mdio_bus_data && priv->plat->mdio_bus_data->has_xpcs) { > /* Currently implemented procedure */ > } > > ... > }
That seems like a good idea to me, although those setup functions would have to be renamed to stmmac_pcs_setup/exit.
Thanks,
-- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |