Messages in this thread | | | Date | Wed, 17 Apr 2024 11:05:27 +0200 | Subject | Re: [PATCH v5 1/5] virt: vmgenid: rearrange code to make review easier | From | Babis Chalios <> |
| |
On 17/4/24 10:35, Alexander Graf wrote: > > On 17.04.24 10:12, Babis Chalios wrote: >> From: Sudan Landge <sudanl@amazon.com> >> >> Rearrage the functions of vmgenid to make the next commit, >> which re-implements vmgenid as a platform driver, easier to review. >> >> Signed-off-by: Sudan Landge <sudanl@amazon.com> > > > You can't sign off on behalf of someone else. The SoB here needs to be > yours. If you are taking over this code from Sudan, I'd suggest to > take over full ownership of it and put your own name as author and SoB > in all patches. >
I thought about it and it seemed weird to me that I take over SoB and authorship since I only touched one line in one of the patches, but I will be taking over the patches, so I can do that if that's the way we things are done.
Does it make sense to at least add "Co-authored-by Sudan Landge <sudanl@amazon.com>" here?
> > Alex > >
| |