lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] platform/x86: asus-wmi: add support for vivobook fan profiles
On Tue, 16 Apr 2024, Mohamed Ghanmi wrote:

> On Tue, Apr 16, 2024 at 03:51:03PM +0300, Ilpo Järvinen wrote:
> > On Sun, 14 Apr 2024, Luke D. Jones wrote:
> >
> > > From: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> > >
> > > Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> > > to adjust power limits.
> > >
> > > These fan profiles have a different device id than the ROG series.


> > > and different order.
> >
> > Fix grammar.
>
> my grammar is not the greatest so i'm finding it hard to know what is
> the error you're referring to but I think that 'add'
> should become 'adds' ?

That's not what I was referring to, you've a dangling/broken "sentence"
right in front of my reply:

"and different order."

Please fix that. Perhaps you just want to remove the stop (".") from
the previous sentence to join the sentences together?

--
i.
\
 
 \ /
  Last update: 2024-04-17 08:29    [W:0.066 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site