lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [net-next PATCH] octeontx2-pf: Add ucast filter count configurability via devlink.
Date

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Tuesday, April 16, 2024 3:53 PM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; Subbaraya
> Sundeep Bhatta <sbhatta@marvell.com>
> Subject: Re: [net-next PATCH] octeontx2-pf: Add ucast filter
> count configurability via devlink.
>
> On Sun, Apr 14, 2024 at 04:28:30PM +0530, Sai Krishna wrote:
> > Added a devlink param to set/modify unicast filter count. Currently
> > it's hardcoded with a macro.
>
> Hi Sai,
>
> I think it would be nice to provide a sample devlink command in the patch
> description, as you did for:
>
> 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry
> count")
>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>

Ack, yeah.. missed to add example command. Will do in patch v2.

>
> ...
>
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
>
> ...
>
> > +static int otx2_dl_ucast_flt_cnt_get(struct devlink *devlink, u32 id,
> > + struct devlink_param_gset_ctx *ctx) {
> > + struct otx2_devlink *otx2_dl = devlink_priv(devlink);
> > + struct otx2_nic *pfvf = otx2_dl->pfvf;
> > +
> > + if (!pfvf->flow_cfg) {
> > + ctx->val.vu8 = 0;
> > + return 0;
> > + }
> > +
> > + ctx->val.vu8 = pfvf->flow_cfg->ucast_flt_cnt;
>
> nit: perhaps this could be more succinctly expressed as follows
> (completely untested!):
>
> ctx->val.vu8 = pfvf->flow_cfg ? pfvf->flow_cfg->ucast_flt_cnt : 0;

Ack, Will submit changes with patch V2.

>
> > +
> > + return 0;
> > +}
>
> ...

\
 
 \ /
  Last update: 2024-04-17 07:18    [W:0.362 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site