Messages in this thread | | | Date | Wed, 17 Apr 2024 16:05:14 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH RFC v2 5/6] blk-throttle: support to destroy throtl_data when blk-throttle is disabled |
| |
Hello,
On Wed, Apr 17, 2024 at 09:39:43AM +0800, Yu Kuai wrote: .. > I guess I'll do lazy init first, and then modularization for rq_qos, > and leave blk-throtl there for now. Perhaps add a new throtl model in > iocost can replace blk-throtl in the future.
That sounds like a plan.
> BTW, currently during test of iocost, I found that iocost can already > achieve that, for example, by following configure: > > echo "$dev enable=1 min=100 max=100" > qos > echo "$dev wbps=4096 wseqiops=1 wrandiops=1" > model > > In the test, I found that wbps and iops is actually limited to the > set value.
Yeah, it shouldn't be too difficult to add .max support to iocost so that you can say something like "this cgroup subtree can't use more than 60% of available capacity". That'd be really cool to have.
Thanks.
-- tejun
| |