lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/6] drm/panel: novatek-nt36672e: stop calling regulator_set_load manually
From


On 4/4/2024 3:08 AM, Dmitry Baryshkov wrote:
> Use .init_load_uA part of the bulk regulator API instead of calling
> register_set_load() manually.

Hi Dmitry,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
> index 9a870b9b6765..20b7bfe4aa12 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c
> @@ -343,17 +343,7 @@ static int nt36672e_1080x2408_60hz_init(struct mipi_dsi_device *dsi)
> static int nt36672e_power_on(struct nt36672e_panel *ctx)
> {
> struct mipi_dsi_device *dsi = ctx->dsi;
> - int ret, i;
> -
> - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
> - ret = regulator_set_load(ctx->supplies[i].consumer,
> - regulator_enable_loads[i]);
> - if (ret) {
> - dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n",
> - ctx->supplies[i].supply, ret);
> - return ret;
> - }
> - }
> + int ret;
>
> ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
> if (ret < 0) {
> @@ -550,8 +540,10 @@ static int nt36672e_panel_probe(struct mipi_dsi_device *dsi)
> return -ENODEV;
> }
>
> - for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++)
> + for (i = 0; i < ARRAY_SIZE(ctx->supplies); i++) {
> ctx->supplies[i].supply = regulator_names[i];
> + ctx->supplies[i].init_load_uA = regulator_enable_loads[i];
> + }
>
> ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
> ctx->supplies);
>
> --
> 2.39.2
>

\
 
 \ /
  Last update: 2024-04-17 23:21    [W:0.133 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site