Messages in this thread | | | Date | Wed, 17 Apr 2024 22:05:45 +0200 | Subject | Re: [PATCH] PCI: qcom: Switch to devm_clk_bulk_get_all() API to get the clocks from Devicetree | From | Konrad Dybcio <> |
| |
On 17.04.2024 9:02 AM, Manivannan Sadhasivam wrote: > There is no need for the device drivers to validate the clocks defined in > Devicetree. The validation should be performed by the DT schema and the > drivers should just get all the clocks from DT. Right now the driver > hardcodes the clock info and validates them against DT which is redundant. > > So use devm_clk_bulk_get_all() that just gets all the clocks defined in DT > and get rid of all static clocks info from the driver. This simplifies the > driver. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > ---
Even better, you can push the bulk_get_all to a common function so as not to duplicate it for every gen!
Konrad
| |