Messages in this thread | | | Date | Wed, 17 Apr 2024 11:39:08 -0700 | From | Isaku Yamahata <> | Subject | Re: [PATCH v2 05/10] KVM: x86/mmu: Introduce kvm_tdp_map_page() to populate guest memory |
| |
On Tue, Apr 16, 2024 at 02:46:17PM +0000, "Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:
> On Wed, 2024-04-10 at 15:07 -0700, isaku.yamahata@intel.com wrote: > > > > +int kvm_tdp_map_page(struct kvm_vcpu *vcpu, gpa_t gpa, u64 error_code, > > + u8 *level) > > +{ > > + int r; > > + > > + /* Restrict to TDP page fault. */ > > + if (vcpu->arch.mmu->page_fault != kvm_tdp_page_fault) > > + return -EINVAL; > > + > > + r = __kvm_mmu_do_page_fault(vcpu, gpa, error_code, false, NULL, > > level); > > Why not prefetch = true? Doesn't it fit? It looks like the behavior will be to > not set the access bit.
Makes sense. Yes, the difference is to set A/D bit or not. -- Isaku Yamahata <isaku.yamahata@intel.com>
| |