Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 17 Apr 2024 20:06:00 +0300 | Subject | Re: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support |
| |
On Wed, Apr 17, 2024 at 8:01 PM Alisa-Dariana Roman <alisadariana@gmail.com> wrote: > > Unlike the other AD719Xs, AD7194 has configurable differential > channels. The user can dynamically configure them in the devicetree. > > Also modify config AD7192 description for better scaling.
..
> + device_for_each_child_node(dev, child) {
You can use scoped variant AFAIU that's available in Jonathan's tree.
> + *ad7194_channels = ad7194_chan_diff; > + ad7194_channels->scan_index = index++; > + ret = ad7194_parse_channel(child, ad7194_channels); > + if (ret) {
> + fwnode_handle_put(child);
With the above this wouldn't be needed.
> + return ret; > + } > + ad7194_channels++; > + }
-- With Best Regards, Andy Shevchenko
| |