Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 16 Apr 2024 23:16:59 +0200 | Subject | Re: [PATCH v1 1/1] gpio: sch: Switch to memory mapped IO accessors |
| |
On Sat, Apr 13, 2024 at 10:31 AM William Breathitt Gray <wbg@kernelorg> wrote: > > On Wed, Apr 10, 2024 at 10:21:02AM +0300, Andy Shevchenko wrote: > > Convert driver to use memory mapped IO accessors. > > > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Acked-by: William Breathitt Gray <wbg@kernel.org> > > A minor suggestion below, but I find this patch accepted as-is. > > > static int sch_gpio_probe(struct platform_device *pdev) > > { > > + struct device *dev = &pdev->dev; > > In general I think this is a good variable to define to simplify all the > &pdev->dev appearing throughout this callback, but I'd rather have seen > it as its own patch so we could change all the other uses of &pdev->dev > at once without distracting from the memory-mapped I/O change of this > particular patch. Not really necessary, but maybe at some point in the > future a follow-up patch doing such a cleanup would be nice. > > William Breathitt Gray
I applied it as is, if anyone wants it, this can be sent on top of it.
Bart
| |