Messages in this thread | | | Subject | Re: [PATCH] bpf: btf: include linux/types.h for u32 | From | Daniel Borkmann <> | Date | Tue, 16 Apr 2024 16:47:38 +0200 |
| |
On 4/16/24 9:28 AM, Jiri Olsa wrote: > On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote: >> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote: >>> lgtm, did it actualy cause problem anywhere? >>> >>> there's also tools/include/linux/btf_ids.h >> >> It caused the problems exactly in the file >> tools/include/linux/btf_ids.h and was reported in >> https://bugzilla.kernel.org/show_bug.cgi?id=218647 >> The patch including linux/types.h in tools/include/linux/btf_ids.h is >> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/ >> I also faced the same compile-error of the form >> >> error: unknown type name 'u32' >> u32 cnt; >> ^~~ >> when compiling the bpf tool with glibc 2.28. >> >> I think it might be reasonable to add the inclusion in >> include/linux/btf_ids.h as well to prevent build problems like this. > > ok, it's in the bpf/master already Please add the error description as motivation aka "why" into the commit description, otherwise it's not really obvious looking at it at a later point in time why the include was needed.
Thanks, Daniel
| |