Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Mon, 15 Apr 2024 02:13:29 +0300 | Subject | Re: [PATCH v2 4/4] arm64: dts: qcom: Add PSCI SYSTEM_RESET2 types for qcm6490-idp |
| |
On Sun, 14 Apr 2024 at 22:32, Elliot Berman <quic_eberman@quicinc.com> wrote: > > Add nodes for the vendor-defined system resets. "bootloader" will cause > device to reboot and stop in the bootloader's fastboot mode. "edl" will > cause device to reboot into "emergency download mode", which permits > loading images via the Firehose protocol. > > Co-developed-by: Shivendra Pratap <quic_spratap@quicinc.com> > Signed-off-by: Shivendra Pratap <quic_spratap@quicinc.com> > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index e4bfad50a669..a966f6c8dd7c 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -126,6 +126,11 @@ debug_vm_mem: debug-vm@d0600000 { > }; > }; > > + psci {
Please use a label instead. Otherwise it looks as if you are adding new device node.
> + mode-bootloader = <0x10001 0x2>; > + mode-edl = <0 0x1>; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > > -- > 2.34.1 > >
-- With best wishes Dmitry
| |