Messages in this thread | | | Date | Sun, 14 Apr 2024 23:31:33 +0300 | Subject | Re: [PATCH v5 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support | From | Alisa-Dariana Roman <> |
| |
On 13.04.2024 22:29, David Lechner wrote: > On Sat, Apr 13, 2024 at 10:13 AM Alisa-Dariana Roman > <alisadariana@gmail.com> wrote: >> >> Unlike the other AD719Xs, AD7194 has configurable differential >> channels. The user can dynamically configure them in the devicetree. >> >> Also add an example for AD7194 devicetree. >> >> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com> >> --- >> .../bindings/iio/adc/adi,ad7192.yaml | 74 +++++++++++++++++++ >> 1 file changed, 74 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml >> index ba506af3b73e..855f0a2d7d75 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml >> @@ -21,8 +21,15 @@ properties: >> - adi,ad7190 >> - adi,ad7192 >> - adi,ad7193 >> + - adi,ad7194 >> - adi,ad7195 >> >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> reg: >> maxItems: 1 >> >> @@ -104,8 +111,43 @@ required: >> - spi-cpol >> - spi-cpha >> >> +patternProperties: >> + "^channel@[0-9]+$": >> + type: object >> + $ref: adc.yaml >> + unevaluatedProperties: false >> + >> + properties: >> + reg: >> + description: The channel index. >> + minimum: 1 >> + maximum: 256 >> + >> + diff-channels: >> + description: | >> + Both inputs can be connected to pins AIN1 to AIN16 by choosing the >> + appropriate value from 1 to 16. >> + items: >> + minimum: 1 >> + maximum: 16 > > Don't we also need to allow 0 for AINCOM here? Or is this property > only for fully differential pairs and not pseudo-differential pairs?
I thought it would be a good idea to have the pseudo-differential pairs set in the driver (all from AIN1 to AIN16 referenced to AINCOM). Only differential ones are fully configurable in the devicetree.
Kind regards, Alisa-Dariana Roman
| |