lkml.org 
[lkml]   [2024]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V5 RESEND 5/5] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V6
    From
    On 13/04/2024 16:20, Jagadeesh Kona wrote:
    > The Venus driver requires vcodec GDSC to be ON in SW mode for clock
    > operations and move it back to HW mode to gain power benefits. Earlier,
    > as there is no interface to switch the GDSC mode from GenPD framework,
    > the GDSC is moved to HW control mode as part of GDSC enable callback and
    > venus driver is writing to its POWER_CONTROL register to keep the GDSC ON
    > from SW whereever required. But the POWER_CONTROL register addresses
    > are not constant and can vary across the variants.
    >
    > Also as per the HW recommendation, the GDSC mode switching needs to be
    > controlled from respective GDSC register and this is a uniform approach
    > across all the targets. Hence use dev_pm_genpd_set_hwmode() API which
    > controls GDSC mode switching using its respective GDSC register.
    >
    > In venus V6 variants, the vcodec gdsc gets enabled in SW mode by default
    > with new HW_CTRL_TRIGGER flag and there is no need to switch it to SW
    > mode again after enable, hence add check to avoid switching gdsc to SW mode
    > again after gdsc enable. Similarly add check to avoid switching GDSC to HW
    > mode before disabling the GDSC, so GDSC gets enabled in SW mode in the next
    > enable.
    >
    > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
    > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
    > ---

    When I tested this out on sm8250 a few months ago it was broken.

    I don't quite see in your commit logs, how the breakage was addressed.

    Can you provide some details ?

    ---
    bod


    \
     
     \ /
      Last update: 2024-05-27 16:40    [W:6.496 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site