lkml.org 
[lkml]   [2024]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] fpga: dfl: remove unused member pdata from struct dfl_{afu,fme}
On Sat, Apr 13, 2024 at 11:10:22AM +0800, Xu Yilun wrote:
> On Mon, Apr 01, 2024 at 02:49:15PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
> > dfl: afu: add afu sub feature support") and to struct dfl_fme in commit

Sorry, I didn't apply. Please don't wrap the git commit description. Put
them in a new line but no wrap, if you have to reference git commit in
changelog.

> > 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
> > support").

This sentence is actually not useful, I suggest you just remove it and
add a Fix: tag below. That makes reviewers quickly find what the
problem. Also avoid the git commit references fragments the changelog
too much.

Thanks,
Yilun

> > It is set in function {afu,fme}_dev_init() but never used.
> >
> > Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Acked-by: Xu Yilun <yilun.xu@intel.com>
>
> Applied to for-next.
>

\
 
 \ /
  Last update: 2024-05-27 16:39    [W:0.050 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site