Messages in this thread | | | From | Dmitry Safonov <> | Date | Sat, 13 Apr 2024 02:50:03 +0100 | Subject | Re: [PATCH net 3/4] selftests/tcp_ao: Fix fscanf() call for format-security |
| |
On Sat, 13 Apr 2024 at 02:43, Dmitry Safonov via B4 Relay <devnull+0x7f454c46.gmail.com@kernel.org> wrote: > > From: Dmitry Safonov <0x7f454c46@gmail.com> > > On my new laptop with packages from nixos-unstable, gcc 12.3.0 produces: > > lib/proc.c: In function ‘netstat_read_type’: > > lib/proc.c:89:9: error: format not a string literal and no format arguments [-Werror=format-security] > > 89 | if (fscanf(fnetstat, type->header_name) == EOF) > > | ^~ > > cc1: some warnings being treated as errors > > Here the selftests lib parses header name, while expectes non-space word > ending with a column. > > Fixes: cfbab37b3da0 ("selftests/net: Add TCP-AO library") > Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Actually, now I see that it was also reported, adding
Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/all/0c6d4f0d-2064-4444-986b-1d1ed782135f@collabora.com/
-- Dmitry
| |