Messages in this thread | | | Date | Sat, 13 Apr 2024 23:13:08 +0300 | Subject | Re: [PATCH] dt-bindings: i2c: qcom-cci: Document sc8280xp compatible | From | Vladimir Zapolskiy <> |
| |
Hi Bryan,
On 4/12/24 16:53, Bryan O'Donoghue wrote: > Add sc8280xp compatible consistent with recent CAMSS CCI interfaces. > > sc8280xp has the following clock list and so requires its own compat > string and sc8280xp specific clock definition in the yaml. > > - const: camnoc_axi > - const: slow_ahb_src > - const: cpas_ahb > - const: cci > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Initially I added a compat string to yaml and driver for sc8280xp but, it > was incomplete and wrong so I asked for a revert. > > Subsequent to posting the compat string I had posted dtsi changes to > sc8280xp to add in the CCI, forgetting to follow up on the compat revert. > > I then completely forgot about the compat string and worse still > misremembered the whole reasoning behind it. > > This one patch series cleans up the mess. > > - The fallback compat qcom,msm8916-cci hooks the driver. > Since there are no driver changes specific to sc8280xp we don't > need to add yet another entry to the CCI driver. > > - The compat string qcom,sc8280xp-cci is additionally declared in > the dts -> compat = "qcom,msm8916-cci", "qcom,sc8280xp-cci"; > The sc8280xp-cci will match the yaml and enforce constraints. > > - The yaml entry for qcom,sc8280xp-cci constrains the list of > clocks which is specific to sc8280xp-cci > > Result: > > - No new redundant compat string in the CCI driver > > - DTS is unchanged > > - YAML expanded to capture missing string >
I believe it's excellent, thank you very much for the change and efforts!
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
-- Best wishes, Vladimir
| |