Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 13 Apr 2024 12:41:21 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] cdx: Convert to platform remove callback returning void |
| |
On Sat, Apr 13, 2024 at 12:12:56PM +0200, Uwe Kleine-König wrote: > Hello Greg, > > On Fri, Mar 08, 2024 at 09:51:05AM +0100, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is ignored (apart > > from emitting a warning) and this typically results in resource leaks. > > > > To improve here there is a quest to make the remove callback return > > void. In the first step of this quest all drivers are converted to > > .remove_new(), which already returns void. Eventually after all drivers > > are converted, .remove_new() will be renamed to .remove(). > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > we just talked in irc about this thread that might have fell through the > cracks on your side. > > Thanks for reconsidering to apply it for v6.10-rc1,
Now applied, thanks.
greg k-h
| ![\](/images/icornerr.gif) |