lkml.org 
[lkml]   [2024]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle
From
On 2024/3/7 22:43, Wenchao Hao wrote:
> I am testing SCSI error handle with my previous scsi_debug error
> injection patches, and found some issues when removing device and
> error handler happened together.
>
> These issues are triggered because devices in removing would be skipped
> when calling shost_for_each_device().
>

Friendly ping...


> The issues are found:
> 1. statistic info printed at beginning of scsi_error_handler is wrong
> 2. device reset is not triggered
>
> V4:
> - Remove the forth patch which fix IO hang when device removing
> becaust the issue is fixed by commit '6df0e077d76bd (scsi: core:
> Kick the requeue list after inserting when flushing)'
>
> V3:
> - Update patch description
> - Update comments of functions added
>
> V2:
> - Fix IO hang by run all devices' queue after error handler
> - Do not modify shost_for_each_device() directly but add a new
> helper to iterate devices but do not skip devices in removing
>
> Wenchao Hao (3):
> scsi: core: Add new helper to iterate all devices of host
> scsi: scsi_error: Fix wrong statistic when print error info
> scsi: scsi_error: Fix device reset is not triggered
>
> drivers/scsi/scsi.c | 46 ++++++++++++++++++++++++++------------
> drivers/scsi/scsi_error.c | 4 ++--
> include/scsi/scsi_device.h | 25 ++++++++++++++++++---
> 3 files changed, 56 insertions(+), 19 deletions(-)
>


\
 
 \ /
  Last update: 2024-04-12 04:07    [W:0.076 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site