lkml.org 
[lkml]   [2024]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/9] media: subdev: Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams()
    Hi Tomi,

    Thank you for the patch.

    On Wed, Apr 10, 2024 at 03:35:49PM +0300, Tomi Valkeinen wrote:
    > Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams().

    Commit messages should explain the reaon for a change. With that,

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
    > ---
    > drivers/media/v4l2-core/v4l2-subdev.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
    > index 13957543d153..4a531c2b16c4 100644
    > --- a/drivers/media/v4l2-core/v4l2-subdev.c
    > +++ b/drivers/media/v4l2-core/v4l2-subdev.c
    > @@ -2133,7 +2133,7 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad,
    > return 0;
    >
    > /* Fallback on .s_stream() if .enable_streams() isn't available. */
    > - if (!sd->ops->pad || !sd->ops->pad->enable_streams)
    > + if (!v4l2_subdev_has_op(sd, pad, enable_streams))
    > return v4l2_subdev_enable_streams_fallback(sd, pad,
    > streams_mask);
    >
    > @@ -2250,7 +2250,7 @@ int v4l2_subdev_disable_streams(struct v4l2_subdev *sd, u32 pad,
    > return 0;
    >
    > /* Fallback on .s_stream() if .disable_streams() isn't available. */
    > - if (!sd->ops->pad || !sd->ops->pad->disable_streams)
    > + if (!v4l2_subdev_has_op(sd, pad, disable_streams))
    > return v4l2_subdev_disable_streams_fallback(sd, pad,
    > streams_mask);
    >
    >

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2024-04-12 19:39    [W:4.894 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site