Messages in this thread | | | Date | Fri, 12 Apr 2024 17:17:04 +0100 | From | Dave Martin <> | Subject | Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate header |
| |
On Mon, Apr 08, 2024 at 08:18:00PM -0700, Reinette Chatre wrote: > Hi James, > > On 3/21/2024 9:50 AM, James Morse wrote: > > To avoid sticky problems in the mpam glue code, move the resctrl > > enums into a separate header. > > Could you please elaborate so that "sticky problems in the mpam glue code" is > specific about what problems are avoided?
Maybe just delete the the sticky clause, and leave:
Move the resctrl enums into a separate header.
..since the next paragraph explains the rationale?
> > > > This lets the arch code declare prototypes that use these enums without > > creating a loop via asm<->linux resctrl.h The same logic applies to the > > monitor-configuration defines, move these too. > > > > The maintainers entry for these headers was missed when resctrl.h > > was created. Add a wildcard entry to match both resctrl.h and > > resctrl_types.h. > > > > Signed-off-by: James Morse <james.morse@arm.com> > > .. > > > diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h > > new file mode 100644 > > index 000000000000..4788bd95dac6 > > --- /dev/null > > +++ b/include/linux/resctrl_types.h > > @@ -0,0 +1,68 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (C) 2024 Arm Ltd. > > + * Based on arch/x86/kernel/cpu/resctrl/internal.h > > + */ > > Could this header please explain how this file is intended to be used? > What is it intended to contain? > > Reinette
Maybe something like the following?
* Resctrl types and constants needed for inline function definitions in * the arch-specific <asm/resctrl.h> headers.
(James might have had other things in mind, but this is what it looks like to me...)
Cheers ---Dave
| |