lkml.org 
[lkml]   [2024]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed
From
On 11.04.24 14:26, Alexander Gordeev wrote:
> On Wed, Mar 27, 2024 at 06:17:36PM +0100, David Hildenbrand wrote:
>
> Hi David,
> ...
>> static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd,
>> struct vm_area_struct *dst_vma,
>> unsigned long dst_addr)
>> @@ -324,6 +355,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd,
>> spinlock_t *ptl;
>> int ret;
>>
>> + if (mm_forbids_zeropage(dst_vma->mm))
>
> I assume, you were going to pass dst_vma->vm_mm here?
> This patch does not compile otherwise.

Ah, I compiled it only on x86, where the parameter is ignored ... and
for testing the code path I forced mm_forbids_zeropage to be 1 on x86.

Yes, this must be dst_vma->vm_mm.

Thanks!

--
Cheers,

David / dhildenb


\
 
 \ /
  Last update: 2024-05-27 16:35    [W:0.049 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site