Messages in this thread | | | Date | Thu, 11 Apr 2024 14:24:58 +0300 | Subject | Re: [PATCH] drivers: thermal: tsens: Fix null pointer dereference | From | Aleksandr Mishin <> |
| |
On 09.04.2024 12:52, Konrad Dybcio wrote: > > > On 4/5/24 11:07, Aleksandr Mishin wrote: >> compute_intercept_slope() is called from calibrate_8960() (in >> tsens-8960.c) >> as compute_intercept_slope(priv, p1, NULL, ONE_PT_CALIB) which lead to >> null >> pointer dereference (if DEBUG or DYNAMIC_DEBUG set). >> Fix this bug by adding null pointer check. >> >> Found by Linux Verification Center (linuxtesting.org) with SVACE. >> >> Fixes: dfc1193d4dbd ("thermal/drivers/tsens: Replace custom 8960 apis >> with generic apis") >> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> >> --- > > Maybe we can replace p2[i] with p2 ? p2[i] : 0
Your solution look better for me. Thanks. I'll offer v2 patch
> > Konrad
-- Kind regards Aleksandr
| |