lkml.org 
[lkml]   [2024]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y
On Thu, Apr 11, 2024 at 09:43:48AM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 9, 2024 at 7:39 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > When CONFIG_PANEL_BOOT_MESSAGE=y the module still includes
> > the generated header and gets rebuilt even if it doesn't use
> > anything from that header. Include generated header conditionally
> > to avoid unnecessary rebuilds.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks for your patch!
>
> > --- a/drivers/auxdisplay/charlcd.c
> > +++ b/drivers/auxdisplay/charlcd.c
> > @@ -17,7 +17,9 @@
> > #include <linux/uaccess.h>
> > #include <linux/workqueue.h>
> >
> > +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> > #include <generated/utsrelease.h>
> > +#endif
>
> Perhaps move the existing "#ifdef CONFIG_PANEL_BOOT_MESSAGE"-block
> up, and move the #include inside the #else branch?

I was thinking about it, but decided to group headers together.

> > #include "charlcd.h"
>
> Regardless
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko



\
 
 \ /
  Last update: 2024-05-27 16:35    [W:0.039 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site