lkml.org 
[lkml]   [2024]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH][next] tipc: remove redundant assignment to ret, simplify code
Date
>--- a/net/tipc/socket.c
>+++ b/net/tipc/socket.c
>@@ -3565,11 +3565,8 @@ int tipc_nl_sk_walk(struct sk_buff *skb, struct netlink_callback *cb,
> rhashtable_walk_start(iter);
> while ((tsk = rhashtable_walk_next(iter)) != NULL) {
> if (IS_ERR(tsk)) {
>- err = PTR_ERR(tsk);
>- if (err == -EAGAIN) {
>- err = 0;
>+ if (PTR_ERR(tsk) == -EAGAIN)
> continue;
>- }
> break;
> }
>
>--
>2.39.2
>
I suggest that err variable should be completely removed. Could you please also do the same thing for this code ?
"
...
err = skb_handler(skb, cb, tsk);
if (err) {
...
}
...
"
\
 
 \ /
  Last update: 2024-05-27 16:35    [W:0.065 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site