Messages in this thread | | | Date | Thu, 11 Apr 2024 11:24:21 +0200 | Subject | Re: [PATCH v10 3/4] clk: stm32: introduce clocks for STM32MP257 platform | From | Gabriel FERNANDEZ <> |
| |
On 4/11/24 08:36, Stephen Boyd wrote: > Quoting gabriel.fernandez@foss.st.com (2024-04-09 10:12:40) >> diff --git a/drivers/clk/stm32/clk-stm32mp25.c b/drivers/clk/stm32/clk-stm32mp25.c >> new file mode 100644 >> index 000000000000..23876e7d9863 >> --- /dev/null >> +++ b/drivers/clk/stm32/clk-stm32mp25.c >> @@ -0,0 +1,1876 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (C) STMicroelectronics 2023 - All Rights Reserved >> + * Author: Gabriel Fernandez <gabriel.fernandez@foss.st.com> for STMicroelectronics. >> + */ >> + >> +#include <linux/clk.h> > Use clk-provider.h not clk.h ok > >> +#include <linux/of_address.h> > Doubt this is the right include. Drop?
yes i will drop
>> +#include <linux/platform_device.h> >> + >> +#include "clk-stm32-core.h" >> +#include "reset-stm32.h" >> +#include "stm32mp25_rcc.h" >> + >> +#include <dt-bindings/clock/st,stm32mp25-rcc.h> > [...] >> + .clock_data = &stm32mp25_clock_data, >> + .reset_data = &stm32mp25_reset_data, >> +}; >> + >> +static const struct of_device_id stm32mp25_match_data[] = { >> + { .compatible = "st,stm32mp25-rcc", .data = &stm32mp25_data, }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, stm32mp25_match_data); >> + >> +static int stm32mp25_rcc_clocks_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + void __iomem *base; >> + >> + base = devm_platform_ioremap_resource(pdev, 0); >> + if (WARN_ON(IS_ERR(base))) > Drop WARN_ON
ok
Thank's
Best Regards
Gabriel
>> + return PTR_ERR(base);
| |