lkml.org 
[lkml]   [2024]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] bcachefs: fix typo in reference to BCACHEFS_DEBUG
From
Also, I am curious why such spelling errors cannot be detected at the 
compilation stage.

On 2024/4/11 16:29, Lukas Bulwahn wrote:
> Commit ec9cc18fc2e6 ("bcachefs: Add checks for invalid snapshot IDs")
> intends to check the sanity of a snapshot and panic when
> BCACHEFS_DEBUG is set, but that conditional has a typo.
>
> Fix the typo to refer to the actual existing Kconfig symbol.
>
> This was found with ./scripts/checkkconfigsymbols.py.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
> fs/bcachefs/snapshot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/snapshot.h b/fs/bcachefs/snapshot.h
> index b7d2fed37c4f..3fdb41b33d2d 100644
> --- a/fs/bcachefs/snapshot.h
> +++ b/fs/bcachefs/snapshot.h
> @@ -77,7 +77,7 @@ static inline u32 __bch2_snapshot_parent(struct bch_fs *c, u32 id)
> return 0;
>
> u32 parent = s->parent;
> - if (IS_ENABLED(CONFIG_BCACHEFS_DEBU) &&
> + if (IS_ENABLED(CONFIG_BCACHEFS_DEBUG) &&
> parent &&
> s->depth != snapshot_t(c, parent)->depth + 1)
> panic("id %u depth=%u parent %u depth=%u\n",

\
 
 \ /
  Last update: 2024-05-27 16:35    [W:0.116 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site