Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 11 Apr 2024 09:23:17 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] mcb: lpc: Convert to platform remove callback returning void |
| |
Hello,
On Thu, Mar 07, 2024 at 06:59:03PM +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant.
I didn't get any feedback in reply to this patch. My quest to change the prototype of struct platform_driver::remove depends on that one, so it would be great if it could make it into the mainline during the next merge window.
I added Greg to Cc: who's tree the last changes to this driver went in through. If I don't get feedback until v6.9, I'd ask him to take this patch without further maintainer feedback.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |