Messages in this thread | | | From | Saravana Kannan <> | Date | Thu, 11 Apr 2024 21:33:16 -0700 | Subject | Re: [PATCH 1/2] checkpatch: Don't check for 75 chars per line for create/delete mode lines |
| |
On Wed, Feb 21, 2024 at 9:15 PM Saravana Kannan <saravanak@google.com> wrote: > > Cover letters have a "create/delete mode <mode> <filename>" line for files > added/deleted in the patch series. Ignore these lines when checking for the > maximum 75 chars per line limit. > > Signed-off-by: Saravana Kannan <saravanak@google.com>
I know patch 2/2 is not going to be picked up. But can we pick up this one please?
-Saravana
> --- > scripts/checkpatch.pl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 9c4c4a61bc83..f306634a938c 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3271,6 +3271,8 @@ sub process { > # filename then : > $line =~ /^\s*(?:Fixes:|$link_tags_search|$signature_tags)/i || > # A Fixes:, link or signature tag line > + $line =~ /^\s*(?:delete|create) mode\s+[0-8]+\s+\S+\s*$/i || > + # A "create/delete mode <mode> <filename>" line found in cover letters > $commit_log_possible_stack_dump)) { > WARN("COMMIT_LOG_LONG_LINE", > "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr); > -- > 2.44.0.rc0.258.g7320e95886-goog >
| |