Messages in this thread | | | Subject | Re: [PATCH net 4/4] net: ravb: Fix RX byte accounting for jumbo packets | From | Sergey Shtylyov <> | Date | Thu, 11 Apr 2024 20:56:08 +0300 |
| |
On 4/11/24 2:44 PM, Paul Barker wrote:
> The RX byte accounting for jumbo packets was changed to fix a potential > use-after-free bug. However, that fix used the wrong variable and so > only accounted for the number of bytes in the final descriptor, not the > number of bytes in the whole packet. > > To fix this, we can simply update our stats with the correct number of > bytes before calling napi_gro_receive(). > > Also rename pkt_len to desc_len in ravb_rx_gbeth() to avoid any future > confusion. The variable name pkt_len is correct in ravb_rx_rcar() as > that function does not handle packets spanning multiple descriptors. > > Fixes: 5a5a3e564de6 ("ravb: Fix potential use-after-free in ravb_rx_gbeth()") > Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
| |