| From | Jens Axboe <> | Subject | [PATCH 433/437] fs/debugfs: remove (now) dead non-iterator debugfs_attr functions | Date | Thu, 11 Apr 2024 09:19:33 -0600 |
| |
Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/debugfs/file.c | 46 ----------------------------------------- include/linux/debugfs.h | 6 ------ 2 files changed, 52 deletions(-)
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 6463b4a274d4..9c8fe0834b2b 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -451,21 +451,6 @@ const struct file_operations debugfs_full_proxy_file_operations = { .open = full_proxy_open, }; -ssize_t debugfs_attr_read(struct file *file, char __user *buf, - size_t len, loff_t *ppos) -{ - struct dentry *dentry = F_DENTRY(file); - ssize_t ret; - - ret = debugfs_file_get(dentry); - if (unlikely(ret)) - return ret; - ret = simple_attr_read(file, buf, len, ppos); - debugfs_file_put(dentry); - return ret; -} -EXPORT_SYMBOL_GPL(debugfs_attr_read); - ssize_t debugfs_attr_read_iter(struct kiocb *iocb, struct iov_iter *to) { struct dentry *dentry = F_DENTRY(iocb->ki_filp); @@ -480,37 +465,6 @@ ssize_t debugfs_attr_read_iter(struct kiocb *iocb, struct iov_iter *to) } EXPORT_SYMBOL_GPL(debugfs_attr_read_iter); -static ssize_t debugfs_attr_write_xsigned(struct file *file, const char __user *buf, - size_t len, loff_t *ppos, bool is_signed) -{ - struct dentry *dentry = F_DENTRY(file); - ssize_t ret; - - ret = debugfs_file_get(dentry); - if (unlikely(ret)) - return ret; - if (is_signed) - ret = simple_attr_write_signed(file, buf, len, ppos); - else - ret = simple_attr_write(file, buf, len, ppos); - debugfs_file_put(dentry); - return ret; -} - -ssize_t debugfs_attr_write(struct file *file, const char __user *buf, - size_t len, loff_t *ppos) -{ - return debugfs_attr_write_xsigned(file, buf, len, ppos, false); -} -EXPORT_SYMBOL_GPL(debugfs_attr_write); - -ssize_t debugfs_attr_write_signed(struct file *file, const char __user *buf, - size_t len, loff_t *ppos) -{ - return debugfs_attr_write_xsigned(file, buf, len, ppos, true); -} -EXPORT_SYMBOL_GPL(debugfs_attr_write_signed); - static ssize_t debugfs_attr_write_iter_xsigned(struct kiocb *iocb, struct iov_iter *from, bool is_signed) diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h index c6d189059d3d..7d08c0900b4c 100644 --- a/include/linux/debugfs.h +++ b/include/linux/debugfs.h @@ -104,14 +104,8 @@ const struct file_operations *debugfs_real_fops(const struct file *filp); int debugfs_file_get(struct dentry *dentry); void debugfs_file_put(struct dentry *dentry); -ssize_t debugfs_attr_read(struct file *file, char __user *buf, - size_t len, loff_t *ppos); ssize_t debugfs_attr_read_iter(struct kiocb *iocb, struct iov_iter *to); -ssize_t debugfs_attr_write(struct file *file, const char __user *buf, - size_t len, loff_t *ppos); ssize_t debugfs_attr_write_iter(struct kiocb *iocb, struct iov_iter *from); -ssize_t debugfs_attr_write_signed(struct file *file, const char __user *buf, - size_t len, loff_t *ppos); ssize_t debugfs_attr_write_iter_signed(struct kiocb *iocb, struct iov_iter *from); struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, -- 2.43.0
|