lkml.org 
[lkml]   [2024]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xfs: replace deprecated strncpy with strscpy_pad
    On Wed, Apr 10, 2024 at 01:45:21PM -0700, Justin Stitt wrote:
    > On Tue, Apr 9, 2024 at 9:22 AM Kees Cook <keescook@chromium.org> wrote:
    > > >
    > > > - /* 1 larger than sb_fname, so this ensures a trailing NUL char */
    > > > - memset(label, 0, sizeof(label));
    > > > spin_lock(&mp->m_sb_lock);
    > > > - strncpy(label, sbp->sb_fname, XFSLABEL_MAX);
    > > > + strscpy_pad(label, sbp->sb_fname);
    > >
    > > Is sbp->sb_fname itself NUL-terminated? This looks like another case of
    > > needing the memtostr() helper?
    > >
    >
    > I sent a patch [1].
    >
    > Obviously it depends on your implementation patch landing first; what
    > tree should it go to?

    This "flavor" of conversion may need to wait a release? There's no
    urgency on the conversion, and there are plenty more to do for this
    cycle. ;)

    -Kees

    > [1]: https://lore.kernel.org/r/20240410-strncpy-xfs-split1-v2-1-7c651502bcb0@google.com

    --
    Kees Cook

    \
     
     \ /
      Last update: 2024-05-27 16:36    [W:2.380 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site