Messages in this thread | | | Date | Thu, 11 Apr 2024 15:13:50 +0100 | From | Dave Martin <> | Subject | Re: [PATCH v1 02/31] x86/resctrl: Add a helper to avoid reaching into the arch code resource list |
| |
On Tue, Apr 09, 2024 at 10:09:20AM +0200, David Hildenbrand wrote: > On 21.03.24 17:50, James Morse wrote: > > Resctrl occasionally wants to know something about a specific resource, > > in these cases it reaches into the arch code's rdt_resources_all[] > > array. > > > > Once the filesystem parts of resctrl are moved to /fs/, this means it > > will need visibility of the architecture specific struct > > resctrl_hw_resource definition, and the array of all resources. > > All architectures would also need a r_resctrl member in this struct. > > > > Instead, abstract this via a helper to allow architectures to do > > different things here. Move the level enum to the resctrl header and > > add a helper to retrieve the struct rdt_resource by 'rid'. > > > > resctrl_arch_get_resource() should not return NULL for any value in > > the enum, it may instead return a dummy resource that is > > !alloc_enabled && !mon_enabled. > > > > Signed-off-by: James Morse <james.morse@arm.com> > > --- > > Reviewed-by: David Hildenbrand <david@redhat.com> > > -- > Cheers, > > David / dhildenb
Thanks; noted for James' attention.
Cheers ---Dave > >
| |