Messages in this thread | | | Date | Wed, 10 Apr 2024 11:55:42 +0200 | Subject | Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove redundant code in lvts_ctrl_configure | From | AngeloGioacchino Del Regno <> |
| |
Il 10/04/24 02:07, Pin-yen Lin ha scritto: > The removed variable assignment is never written to the register, so it > has no effect on the device behavior. Mediatek has confirmed that it > is not required to initialize this register for current platforms, so > remove this segment to avoid confusion. > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> >
Added Nicolas Pitre to the loop;
Nicolas, since you're pushing support for those, can you please check if CALSCALE is used/useful/necessary on MT8186/88 before I give a R-b to this commit?
P.S.: Can anyone from MediaTek please confirm if the 0x300 value is right for this register? I'd still like Linux to properly initialize the registers, even if this could technically be a default value.
> --- > > drivers/thermal/mediatek/lvts_thermal.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index fd4bd650c77a..48d2f8ba3f18 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -985,12 +985,6 @@ static int lvts_ctrl_configure(struct device *dev, struct lvts_ctrl *lvts_ctrl) > value = LVTS_TSSEL_CONF; > writel(value, LVTS_TSSEL(lvts_ctrl->base)); > > - /* > - * LVTS_CALSCALE : ADC voltage round > - */ > - value = 0x300; > - value = LVTS_CALSCALE_CONF;
As a side note, I believe that the original author wanted to write, instead...
value = LVTS_CALSCALE_CONF; writel(value, LVTS_CALSCALE(lvts_ctrl->base);
Cheers, Angelo
> - > /* > * LVTS_MSRCTL0 : Sensor filtering strategy > *
| |