Messages in this thread | | | Date | Wed, 10 Apr 2024 10:34:06 +0200 | Subject | Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio | From | David Hildenbrand <> |
| |
On 09.04.24 11:28, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" <alexs@kernel.org> > > The ksm only contains single pages, so we could add a new func > ksm_get_folio for get_ksm_page to use folio instead of pages to save a > couple of compound_head calls. > > After all caller replaced, get_ksm_page will be removed. > > Signed-off-by: Alex Shi (tencent) <alexs@kernel.org> > To: Andrew Morton <akpm@linux-foundation.org> > Cc: Izik Eidus <izik.eidus@ravellosystems.com> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Hugh Dickins <hughd@google.com> > Cc: Chris Wright <chrisw@sous-sol.org> > Reviewed-by: David Hildenbrand <david@redhat.com> > --- > mm/ksm.c | 40 ++++++++++++++++++++++++---------------- > 1 file changed, 24 insertions(+), 16 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 8c001819cf10..ac080235b002 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -915,10 +915,10 @@ enum get_ksm_page_flags { > * a page to put something that might look like our key in page->mapping. > * is on its way to being freed; but it is an anomaly to bear in mind. > */ > -static struct page *get_ksm_page(struct ksm_stable_node *stable_node, > +static struct folio *ksm_get_folio(struct ksm_stable_node *stable_node,
Just realized that you should adjust the function name in the comment above this function in this patch.
-- Cheers,
David / dhildenb
| |