lkml.org 
[lkml]   [2024]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] x86: platform: iris: Convert to platform remove callback returning void
    Date
    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart
    from emitting a warning) and this typically results in resource leaks.

    To improve here there is a quest to make the remove callback return
    void. In the first step of this quest all drivers are converted to
    remove_new(), which already returns void. Eventually after all drivers
    are converted, .remove_new() will be renamed to .remove().

    Trivially convert this driver from always returning zero in the remove
    callback to the void returning variant.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    arch/x86/platform/iris/iris.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/platform/iris/iris.c b/arch/x86/platform/iris/iris.c
    index b42bfdab01a9..c5f3bbdbdcfe 100644
    --- a/arch/x86/platform/iris/iris.c
    +++ b/arch/x86/platform/iris/iris.c
    @@ -62,11 +62,10 @@ static int iris_probe(struct platform_device *pdev)
    return 0;
    }

    -static int iris_remove(struct platform_device *pdev)
    +static void iris_remove(struct platform_device *pdev)
    {
    pm_power_off = old_pm_power_off;
    printk(KERN_INFO "Iris power_off handler uninstalled.\n");
    - return 0;
    }

    static struct platform_driver iris_driver = {
    @@ -74,7 +73,7 @@ static struct platform_driver iris_driver = {
    .name = "iris",
    },
    .probe = iris_probe,
    - .remove = iris_remove,
    + .remove_new = iris_remove,
    };

    static struct resource iris_resources[] = {
    --
    2.43.0

    \
     
     \ /
      Last update: 2024-05-27 16:32    [W:3.702 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site