Messages in this thread | | | Date | Wed, 10 Apr 2024 14:32:31 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v2 4/4] dt-bindings: PCI: mediatek,mt7621-pcie: switch from deprecated pci-bus.yaml |
| |
On Wed, 10 Apr 2024 20:15:21 +0200, Krzysztof Kozlowski wrote: > dtschema package with core schemas deprecated pci-bus.yaml schema in > favor of individual schemas per host, device and pci-pci. > > Switch Mediatek MT7621 PCIe host bridge binding to this new schema. > > This requires dtschema package newer than v2024.02 to work fully. > v2024.02 will partially work: with a warning. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Important: v2024.03 (said dtschema newer than v2024.02) was not yet > released, therefore this patch probably should wait a bit. Previous > patches do not depend anyhow on future release, so they can be taken as > is. > > Changes in v2: > 1. New patch > 2. Split mediatek,mt7621-pcie to separate patch as it uses > pci-pci-bridge schema. > --- > .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@0,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@1,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.example.dtb: pcie@1e140000: pcie@2,0: Unevaluated properties are not allowed ('clocks', 'phy-names', 'phys', 'resets' were unexpected) from schema $id: http://devicetree.org/schemas/pci/mediatek,mt7621-pcie.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410181521.269431-4-krzysztof.kozlowski@linaro.org
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |