Messages in this thread | | | Date | Wed, 10 Apr 2024 20:52:14 +0200 | Subject | Re: [PATCH net-next v1 12/12] mm: page_frag: update documentation and maintainer for page_frag | From | David Hildenbrand <> |
| |
On 10.04.24 20:19, Alexander Duyck wrote: > On Wed, Apr 10, 2024 at 9:06 AM David Hildenbrand <david@redhat.com> wrote: >> >> On 09.04.24 17:11, Alexander Duyck wrote: >>> On Tue, Apr 9, 2024 at 6:25 AM Jakub Kicinski <kuba@kernel.org> wrote: >>>> >>>> On Tue, 9 Apr 2024 15:59:58 +0800 Yunsheng Lin wrote: >>>>>> Just to be clear this isn't an Ack, but if you are going to list >>>>>> maintainers for this my name should be on the list so this is the >>>>>> preferred format. There are still some things to be cleaned up in this >>>>>> patch. >>>>> >>>>> Sure, I was talking about "Alexander seems to be the orginal author for >>>>> page_frag, we can add him to the MAINTAINERS later if we have an ack from >>>>> him." in the commit log. >>>> >>>> Do we have to have a MAINTAINERS entry for every 1000 lines of code? >>>> It really feels forced :/ >>> >>> I don't disagree. However, if nothing else I think it gets used as a >>> part of get_maintainers.pl that tells you who to email about changes >>> doesn't it? It might make sense in my case since I am still >>> maintaining it using my gmail account, but I think the commits for >>> that were mostly from my Intel account weren't they? So if nothing >>> else it might be a way to provide a trail of breadcrumbs on how to >>> find a maintainer who changed employers.. >> >> Would a .mailmap entry also help for your case, such that the mail >> address might get mapped to the new one? (note, I never edited .mailmap >> myself) > > Not sure. My concern is that it might undo the existing tracking for > contributions by employer as I know they use the emails for the most > basic setup for that. I suppose that is one downside of being a job > hopper.. :-P
I wouldn't be concerned about undoing existing tracking. I can spot people in .mailmap with more than 5 entries / different employers, so it is quite common!
> > I'd rather not make more work for someone like Jon Corbet or Jakub who > I know maintain statistics based on the emails used and such.
From what I recall, they do have their own mapping of mail addresses to employers, for example for people that just don't use corporate mail addresses.
-- Cheers,
David / dhildenb
| |