Messages in this thread | ![/](/images/icornerl.gif) | | From | Christophe Leroy <> | Subject | Re: [RESEND PATCH net v4 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock | Date | Wed, 10 Apr 2024 04:54:31 +0000 |
| |
Hi Vladimir,
Le 19/02/2024 à 16:30, Vladimir Oltean a écrit : > Hi Sean, > > On Thu, Feb 15, 2024 at 11:23:26AM -0500, Sean Anderson wrote: >> smp_call_function_single disables IRQs when executing the callback. To >> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. >> This is already done by qman_update_cgr and qman_delete_cgr; fix the >> other lockers. >> >> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") >> CC: stable@vger.kernel.org >> Signed-off-by: Sean Anderson <sean.anderson@seco.com> >> Reviewed-by: Camelia Groza <camelia.groza@nxp.com> >> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> --- >> I got no response the first time I sent this, so I am resending to net. >> This issue was introduced in a series which went through net, so I hope >> it makes sense to take it via net. >> >> [1] https://lore.kernel.org/linux-arm-kernel/20240108161904.2865093-1-sean.anderson@seco.com/ >> >> (no changes since v3) >> >> Changes in v3: >> - Change blamed commit to something more appropriate >> >> Changes in v2: >> - Fix one additional call to spin_unlock > > Leo Li (Li Yang) is no longer with NXP. Until we figure out within NXP > how to continue with the maintainership of drivers/soc/fsl/, yes, please > continue to submit this series to 'net'. I would also like to point > out to Arnd that this is the case. > > Arnd, a large portion of drivers/soc/fsl/ is networking-related > (dpio, qbman). Would it make sense to transfer the maintainership > of these under the respective networking drivers, to simplify the > procedures?
I see FREESCALE QUICC ENGINE LIBRARY (drivers/soc/fsl/qe/) is maintained by Qiang Zhao <qiang.zhao@nxp.com> but I can't find any mail from him in the past 4 years in linuxppc-dev list, and everytime I wanted to submit something I only got responses from Leo Ly.
The last commit he reviewed is 661ea25e5319 ("soc: fsl: qe: Replace one-element array and use struct_size() helper"), it was in May 2020.
Is he still working at NXP and actively maintaining that library ? Keeping this part maintained is vital for me as this SOC is embedded in the two powerpc platform I maintain (8xx and 83xx).
If Qiang Zhao is not able to activaly maintain that SOC anymore, I volonteer to maintain it.
Thanks Christophe
| ![\](/images/icornerr.gif) |