Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 10 Apr 2024 09:29:01 -0700 | Subject | Re: [PATCHSET 0/6] perf annotate: Add TUI support for data type profiling (v1) |
| |
On Tue, Apr 9, 2024 at 4:50 PM Namhyung Kim <namhyung@kernel.org> wrote: > > Hello, > > This is to support interactive TUI browser for type annotation. > > Like the normal (code) annotation, it should be able to display the data type > annotation. Now `perf annotate --data-type` will show the result in TUI by > default if it's enabled. Also `perf report -s type` can show the same output > using a menu item. > > It's still in a very early stage and supports the basic functionalities only. > I'll work on more features like in the normal annotation browser later. > > The code is also available at 'perf/annotate-data-tui-v1' branch at > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Thanks, > Namhyung > > > Namhyung Kim (6): > perf annotate: Show progress of sample processing > perf annotate-data: Add hist_entry__annotate_data_tty() > perf annotate-data: Add hist_entry__annotate_data_tui() > perf annotate-data: Support event group display in TUI > perf report: Add a menu item to annotate data type in TUI > perf report: Do not collect sample histogram unnecessarily
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> tools/perf/builtin-annotate.c | 149 ++++-------- > tools/perf/builtin-report.c | 7 +- > tools/perf/ui/browsers/Build | 1 + > tools/perf/ui/browsers/annotate-data.c | 312 +++++++++++++++++++++++++ > tools/perf/ui/browsers/hists.c | 31 +++ > tools/perf/util/annotate-data.c | 113 +++++++++ > tools/perf/util/annotate-data.h | 6 + > tools/perf/util/annotate.c | 7 + > 8 files changed, 515 insertions(+), 111 deletions(-) > create mode 100644 tools/perf/ui/browsers/annotate-data.c > > > base-commit: 9c3e9af74326978ba6f4432bb038e6c80f4f56fd > -- > 2.44.0.478.gd926399ef9-goog >
| |