lkml.org 
[lkml]   [2024]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 3/4] perf/x86/amd: support capturing LBR from software events
    Date
    Upstream commit c22ac2a3d4bd ("perf: Enable branch record for software
    events") added ability to capture LBR (Last Branch Records) on Intel CPUs
    from inside BPF program at pretty much any arbitrary point. This is
    extremely useful capability that allows to figure out otherwise
    hard to debug problems, because LBR is now available based on some
    application-defined conditions, not just hardware-supported events.

    retsnoop ([0]) is one such tool that takes a huge advantage of this
    functionality and has proved to be an extremely useful tool in
    practice.

    Now, AMD Zen4 CPUs got support for similar LBR functionality, but
    necessary wiring inside the kernel is not yet setup. This patch seeks to
    rectify this and follows a similar approach to the original patch
    for Intel CPUs. We implement an AMD-specific callback set to be called
    through perf_snapshot_branch_stack static call.

    Previous preparatory patches ensured that amd_pmu_core_disable_all() and
    __amd_pmu_lbr_disable() will be completely inlined and will have no
    branches, so LBR snapshot contamination will be minimized.

    This was tested on AMD Bergamo CPU and worked well when utilized from
    the aforementioned retsnoop tool.

    [0] https://github.com/anakryiko/retsnoop

    Reviewed-by: Sandipan Das <sandipan.das@amd.com>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    ---
    arch/x86/events/amd/core.c | 35 +++++++++++++++++++++++++++++++++++
    1 file changed, 35 insertions(+)

    diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
    index 9b15afda0326..1fc4ce44e743 100644
    --- a/arch/x86/events/amd/core.c
    +++ b/arch/x86/events/amd/core.c
    @@ -907,6 +907,37 @@ static int amd_pmu_handle_irq(struct pt_regs *regs)
    return amd_pmu_adjust_nmi_window(handled);
    }

    +/*
    + * AMD-specific callback invoked through perf_snapshot_branch_stack static
    + * call, defined in include/linux/perf_event.h. See its definition for API
    + * details. It's up to caller to provide enough space in *entries* to fit all
    + * LBR records, otherwise returned result will be truncated to *cnt* entries.
    + */
    +static int amd_pmu_v2_snapshot_branch_stack(struct perf_branch_entry *entries, unsigned int cnt)
    +{
    + struct cpu_hw_events *cpuc;
    + unsigned long flags;
    +
    + /*
    + * The sequence of steps to freeze LBR should be completely inlined
    + * and contain no branches to minimize contamination of LBR snapshot
    + */
    + local_irq_save(flags);
    + amd_pmu_core_disable_all();
    + __amd_pmu_lbr_disable();
    +
    + cpuc = this_cpu_ptr(&cpu_hw_events);
    +
    + amd_pmu_lbr_read();
    + cnt = min(cnt, x86_pmu.lbr_nr);
    + memcpy(entries, cpuc->lbr_entries, sizeof(struct perf_branch_entry) * cnt);
    +
    + amd_pmu_v2_enable_all(0);
    + local_irq_restore(flags);
    +
    + return cnt;
    +}
    +
    static int amd_pmu_v2_handle_irq(struct pt_regs *regs)
    {
    struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
    @@ -1443,6 +1474,10 @@ static int __init amd_core_pmu_init(void)
    static_call_update(amd_pmu_branch_reset, amd_pmu_lbr_reset);
    static_call_update(amd_pmu_branch_add, amd_pmu_lbr_add);
    static_call_update(amd_pmu_branch_del, amd_pmu_lbr_del);
    +
    + /* Only support branch_stack snapshot on perfmon v2 */
    + if (x86_pmu.handle_irq == amd_pmu_v2_handle_irq)
    + static_call_update(perf_snapshot_branch_stack, amd_pmu_v2_snapshot_branch_stack);
    } else if (!amd_brs_init()) {
    /*
    * BRS requires special event constraints and flushing on ctxsw.
    --
    2.43.0

    \
     
     \ /
      Last update: 2024-05-27 16:18    [W:4.683 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site