Messages in this thread | | | Date | Mon, 1 Apr 2024 10:49:50 -0700 | Subject | Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe() | From | Bart Van Assche <> |
| |
On 12/8/23 00:23, linan666@huaweicloud.com wrote: > From: Li Nan <linan122@huawei.com> > > "if device_add() succeeds, you should call device_del() when you want to > get rid of it." > > In sd_probe(), device_add_disk() fails when device_add() has already > succeeded, so change put_device() to device_unregister() to ensure device > resources are released. > > Fixes: 2a7a891f4c40 ("scsi: sd: Add error handling support for add_disk()") > Signed-off-by: Li Nan <linan122@huawei.com> > --- > drivers/scsi/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 542a4bbb21bc..d81cbeee06eb 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3736,7 +3736,7 @@ static int sd_probe(struct device *dev) > > error = device_add_disk(dev, gd, NULL); > if (error) { > - put_device(&sdkp->disk_dev); > + device_unregister(&sdkp->disk_dev); > put_disk(gd); > goto out; > }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |