lkml.org 
[lkml]   [2024]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 02/10] rcu: Move rcu_preempt_depth_set() to rcupdate.h
Date


> On Mar 31, 2024, at 9:46 PM, Lai Jiangshan <jiangshanlai@gmail.com> wrote:
>
> On Sun, Mar 31, 2024 at 7:10 PM Joel Fernandes <joel@joelfernandes.org> wrote:
>>
>>
>>
>>>> On Mar 28, 2024, at 1:20 PM, Lai Jiangshan <jiangshanlai@gmail.com> wrote:
>>>
>>> From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
>>>
>>> Prepare for arch-specific-defined rcu_preempt_depth_set().
>>>
>>> No functionality change intended, but it has to be defined as a macro
>>> as rcupdate.h is a very low level header included from areas that don't
>>> even know about the task struct "current".
>>
>> Sorry I did not follow changelog. If some rcupdate.h includers do not know
>> about task_struct, how does adding a macro that uses current help?
>>
>
> Hello
>
> This is how macro works and it expands blindly based on tokens on the
> usage-sites.
>
> And rcu_preempt_depth() & rcu_preempt_depth_set() are not universally
> used wrappers, the user can simply also include linux/sched.h to make
> they work.

Oh I see, so by hiding it in a macro, the code remains unexpanded. That makes sense..

Thanks.





>
> Thanks
> Lai

\
 
 \ /
  Last update: 2024-05-27 16:17    [W:0.042 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site