lkml.org 
[lkml]   [2024]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: apple: Fix dependency on 16kB pages
On Mon, 01 Apr 2024 13:23:27 +0100,
"Arnd Bergmann" <arnd@arndb.de> wrote:
>
> On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote:
> > While d3e5bab923d3 consolidated the various definitions for page sizes,
> > it ended up breaking the Apple PCIe driver, which still depends on
> > ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver
> > selectable again.
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: "Krzysztof Wilczyński" <kw@linux.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size
> > configuration")
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> The dependency only exists in the asahi kernel with commit
> db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT = 14")
> and is not present upstream.

You are absolutely right, and I should have checked where this
dependency was coming from.

Apologies for the noise.

M.

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2024-05-27 16:18    [W:0.463 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site